[2/6] shdocvw: Implement InterneExplorer::ExecWB

Jacek Caban jacek at codeweavers.com
Wed Jul 21 07:43:59 CDT 2010

  On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote:
> Implement InterneExplorer::ExecWB
+    if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&Target) != S_OK)
+    {
+        return E_NOTIMPL;

It doesn't seem like a right error code.

+    } else
+    {

You don't really need else block if you return in if anyway.

+        HRESULT ret = IOleCommandTarget_Exec(Target,&CGID_MSHTML, cmdID, cmdexecopt, pvaIn, pvaOut);

Did you test that it should use CGID_MSHTML? I'm not saying that it's wrong and writing a test for winetest would be tricky, but I'd like to know that it's somehow confirmed, esp. because you depend on it in next patches.


More information about the wine-devel mailing list