[1/5] gameux: Add initial implementation of gameux.dll

André Hentschel nerv at dawncrow.de
Wed Jul 21 12:10:49 CDT 2010

Am 21.07.2010 19:01, schrieb Mariusz Pluciński:
> W dniu 19.07.2010 15:02, Henri Verbeet pisze:
>> 2010/7/18 Mariusz Pluciński<vshader at gmail.com>:
>>> +static HINSTANCE hInstance;
>> This is unused.
>> You're mixing tabs and spaces, and have a couple of trailing spaces.
>> Also:
>>> + *      DllRegisterServer (OLEAUT32.@)
> The code of "my" regsvr.c is almost non-modified copy of the same
> file in oleaut32.dll implementation. If it's bad formatted, why it
> exists in official Wine code?

For the same reason why intentation patches are not accepted, because it makes the use of "git blame" hard.

> However, I modified my copy to fulfill Wine's formatting assumptions
> and resent it. Hope it's acceptable now.

That's the right way.


Best Regards, André Hentschel

More information about the wine-devel mailing list