[6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

Alexandre Julliard julliard at winehq.org
Thu Jul 22 07:55:59 CDT 2010

Paul Vriens <paul.vriens.wine at gmail.com> writes:

> On 07/22/2010 02:03 PM, Andrew Nguyen wrote:
>> There are a few things I'm wondering about:
>> When the winetest shlwapi binary was built, what made the compiler
>> decide to import shell32 for the problematic string functions? Neither
>> my local cross-compile build nor the build that the test bot performs
>> seemed to do this. I notice that shell32 is the first import listed in
>> dlls/shlwapi/tests/Makefile.in. Was it possible that the listed import
>> order influenced how the compiler linked the string functions, and would
>> changing the import order be preferable to explicitly loading string
>> functions that seem to be available on all shlwapi versions?
> No clue. If we want to test some function in shlwapi however why not
> explicitly load them?

The order matters, so functions will be resolved to shell32 first. A
better fix is to get rid of the shell32 import. We do want to import
shlwapi to test ordinal imports.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list