[PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

Max TenEyck Woodbury max at mtew.isa-geek.net
Sat Jul 24 10:10:43 CDT 2010


On 07/24/2010 10:58 AM, Nikolay Sivov wrote:
> On 7/24/2010 18:51, Max TenEyck Woodbury wrote:
>> ---
>> dlls/ntdll/file.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
>> index 0a6ee55..86c200f 100644
>> --- a/dlls/ntdll/file.c
>> +++ b/dlls/ntdll/file.c
>> @@ -2148,6 +2148,11 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE
>> handle, PIO_STATUS_BLOCK io,
>> io->u.Status = STATUS_INVALID_PARAMETER_3;
>> break;
>>
>> + /* Invalid requests - do not need 'fixing'. */
>> + case FileAllInformation:
>> + io->u.Status = STATUS_NOT_IMPLEMENTED;
>> + break;
>> +
>> default:
>> FIXME("Unsupported class (%d)\n", class);
>> io->u.Status = STATUS_NOT_IMPLEMENTED;
> Add a test please, and a comment won't be needed with a test too.
>
There already is a test in dlls/ntdll/test/file.c. It produces a
'fixme:' when it should not. This fixes that.



More information about the wine-devel mailing list