[PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.
jjmckenzie51 at earthlink.net
Sun Jul 25 08:45:33 CDT 2010
Max TenEyck Woodbury wrote:
> dlls/ntdll/file.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
> diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
> index 0a6ee55..86c200f 100644
> --- a/dlls/ntdll/file.c
> +++ b/dlls/ntdll/file.c
> @@ -2148,6 +2148,11 @@ NTSTATUS WINAPI NtSetInformationFile(HANDLE handle, PIO_STATUS_BLOCK io,
> io->u.Status = STATUS_INVALID_PARAMETER_3;
> + /* Invalid requests - do not need 'fixing'. */
> + case FileAllInformation:
> + io->u.Status = STATUS_NOT_IMPLEMENTED;
> + break;
> FIXME("Unsupported class (%d)\n", class);
> io->u.Status = STATUS_NOT_IMPLEMENTED;
I think you missed what Nicolay and Dmitry are trying to tell you.
We are trying to implement, bug for bug, the functionality of what
Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when this
call is made? If not, your fix is WRONG. Silencing a 'fixme' is NOT a
fix and this will be REJECTED.
If this is correct and is what Windows does, then state so. Otherwise,
withdraw the patch and fix it the right way.
More information about the wine-devel