[PATCH] const variables are not compile-time constants
mstefani at redhat.com
Mon Jul 26 10:08:24 CDT 2010
Henri Verbeet wrote:
> On 26 July 2010 10:00, Alexandre Julliard <julliard at winehq.org> wrote:
>> Octavian Voicu <octavian.voicu at gmail.com> writes:
>>> On Sun, Jul 25, 2010 at 11:36 PM, Mikko Rasa <tdb at tdb.fi> wrote:
>>>> - static const DWORD user_flags = clip_flags | DCX_NORESETATTRS; /* flags that can be set by user */
>>>> + static const DWORD user_flags = DCX_PARENTCLIP | DCX_CLIPSIBLINGS | DCX_CLIPCHILDREN | DCX_WINDOW
>>>> + | DCX_NORESETATTRS; /* flags that can be set by user */
>>> This should be committed first thing tomorrow imho (in order to
>>> minimize the number of potential compile errors in case of a bisect).
>> Doing a bisect with custom compile flags is not a good idea. That sort
>> of thing happens from time to time.
> It fails for me with gcc 4.4.4 on Debian squeeze, without particularly
> special compile flags. Maybe it's a Debian thing, but you don't have
> to try very hard to run into this.
Works for me with the gcc 4.4.4 on F13 but it breaks with the old 3.1.1
gcc used by the old Smatch.
More information about the wine-devel