[PATCH] d3dx9_36/tests: Added HLSL test suite. (Try 2)

Jeff Zaroyko jeffzaroyko at gmail.com
Fri Jul 30 22:41:34 CDT 2010


On Sat, Jul 31, 2010 at 1:21 PM, Marvin <testbot at testbot.winehq.org> wrote:
>
> === WXPPROSP3 (32 bit hlsl) ===
> hlsl.c:104: Test failed: Could not create device, IDirect3D9_CreateDevice returned: 8876086a
> No test summary line found
> ...further CreateDevice test failures snipped...

Is the purpose of these tests device creation?  If not, then it
doesn't really make any sense to do:

> ok(SUCCEEDED(hres), "Could not create device, IDirect3D9_CreateDevice returned: %08x\n", hres);

It would make more sense to just test the result of SUCCEEDED(hres)
and then skip the tests if it's not possible to create the device
rather than counting it as a failed test.

Jeff



More information about the wine-devel mailing list