propsys: mention that the functions are stubs
fgouget at free.fr
Tue Jun 15 03:25:55 CDT 2010
On Mon, 14 Jun 2010, André Hentschel wrote:
> Am 14.06.2010 22:01, schrieb Hans Leidekker:
> > On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote:
> >> Hans might have missed that
> > No, to me a fixme that prints a parameter list without further
> > explanation implies that the function is a stub.
> That's somehow true, but for easier reading it is better i guess.
> Also i think the apistats parser also checks for something like
> "FIXME(.*)stub" and calls it pseudo stubs if i remember correctly.
> Even if apistats dont work we should keep that style.
Just to confirm what André said, if the FIXME does not contain the word
'stub', then apistats has no way to know it's a (pseudo-)stub. I would
further argue that even a human reading the log would have no way to
know as quite a few implemented functions still dump their parameters.
So even for humans it's better to add 'stub' to the FIXME message.
Francois Gouget <fgouget at free.fr> http://fgouget.free.fr/
Linux: the choice of a GNU generation
More information about the wine-devel