[hhctrl.ocx] Null pointer fix, new patch
jardasmid at gmail.com
Tue Jun 22 07:13:02 CDT 2010
There is actually variable named "null" in the original source code,
just read the whole function. It contains one character - terminating
null. patch fixes http://bugs.winehq.org/show_bug.cgi?id=23247, see it
for more information.
On Tue, Jun 22, 2010 at 1:09 PM, Andrew Nguyen <arethusa26 at gmail.com> wrote:
> On Tue, Jun 22, 2010 at 5:56 AM, Jaroslav Šmíd <jardasmid at gmail.com> wrote:
>> - info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle);
>> + info->WinType.pszCaption=strdupW(info->pCHMInfo->defTitle ?
>> info->pCHMInfo->defTitle : null);
> Perhaps I am missing something obvious, but isn't the new statement
> practically the same as the one you removed? Adding a conditional
> doesn't seem to change what strdupW receives, and thus what it
> ultimately returns.
>> - info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic);
>> + info->WinType.pszFile=strdupW(info->pCHMInfo->defTopic ?
>> info->pCHMInfo->defTopic : null);
> Same thing. Also, did you actually compile and test this patch? I
> would think that writing "null" wouldn't compile.
More information about the wine-devel