[PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

Misha Koshelev misha680 at gmail.com
Fri Jun 25 13:26:55 CDT 2010

On Fri, 2010-06-25 at 18:59 +0200, Henri Verbeet wrote:
> On 25 June 2010 18:20, Misha Koshelev <misha680 at gmail.com> wrote:
> >> regard, although there are (very) minor issues like using %d for
> >> unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9
> >> over simply "IDirect3DDevice9 *".
> >
> > Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests. But I will heed
> > your advice on the %d's
> >
> I wouldn't object to a patch based on either of those alone, but if
> you'll have to resend anyway I might as well point those out.

Very well then. Let's just leave the deferred patch as is if that's okay

and I'll send out further patches post-code freeze heeding all of your

Thank you

More information about the wine-devel mailing list