[PATCH] ole32: fix composite moniker behaviour.

Alexandre Julliard julliard at winehq.org
Tue Mar 2 04:51:36 CST 2010


Reece Dunn <msclrhd at googlemail.com> writes:

> @@ -365,8 +365,7 @@ CompositeMonikerImpl_BindToObject(IMoniker* iface, IBindCtx* pbc,
>              /* if the requested class was loaded before ! we don't need to reload it */
>              res = IRunningObjectTable_GetObject(prot,iface,(IUnknown**)ppvResult);
>  
> -            if (res==S_OK)
> -                return res;
> +            return res==S_OK ? S_OK : E_INVALIDARG;

This doesn't look right. Just because the test wants E_INVALIDARG
doesn't mean it's the correct error for all possible failures.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list