cmd: fix buffer overflow in WCMD_run_program

Detlef Riekenberg wine.dev at web.de
Thu Mar 4 15:44:56 CST 2010


On Do, 2010-03-04 at 09:20 -0800, Eric Ho wrote:
Hi Eric.
Welcome to Wine.

> Fixes http://bugs.winehq.org/show_bug.cgi?id=21344.  Overflows fixed:
> 1. overflow due to long path name (unchecked memcpy,strcpy to thisDir)
> 2. overflow due to long file name (unchecked strcpy into stemofsearch)
> 3. overflow due to concatenating thisDir into stemofsearch (strcat)
> 4. added early breaks when getFullPathName returns an error
> 5. fixed incorrect errorlevel code (needs to be 9023 and it was 9009)

Only fix one problem in a patch please.
This list is a good indicator, how to split your patch.
Use wine-patches at winehq.org for the updated patchset.

Thanks for helping WIne

-- 
By by ... Detlef





More information about the wine-devel mailing list