shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 6]
Paul Vriens
paul.vriens.wine at gmail.com
Mon Mar 8 10:48:19 CST 2010
On 03/08/2010 05:42 PM, Juan Lang wrote:
> Hi Ilya,
> I like this one rather better, thanks. Especially the use of broken()
> makes it clearer what's happening.
>
> I think you could tidy it up just a little more:
>
>> + expected = 33; sprintf(fileA, testfile, tmpdir);
>> + rc=shell_execute(NULL, fileA, NULL, NULL);
>> + todo_wine {
>> + ok(rc==expected || (rc>32&& expected>32),
>> + "expected %s (%d), got %s (%d), lpFile: %s \n",
>> + expected==33 ? "success" : "failure", expected, rc> 32 ? "success" : "failure", rc, fileA
>> + );
>> + }
>
> In this case, expected is 33, so the "expected == 33" is unneeded.
> Just replace "%s (%d)" with "success (32)". Same below with the
> remaining ok expressions: make them match the actual value of
> expected, rather than any possible value. Otherwise, looks good to
> me.
Yep, I like this one better as well. The only thing I see is that you
have "==expected" and "rc>32" (which is both true in the above case). Is
that to cover for OS differences? If so, please add some comments.
--
Cheers,
Paul.
More information about the wine-devel
mailing list