wineaudiofile.acm: Initial commit

Henri Verbeet hverbeet at gmail.com
Fri Mar 12 10:32:45 CST 2010


Not claiming to know a whole lot about OS X or audio, but these are
some general things I noticed:

On 12 March 2010 16:41, Aric Stewart <aric at codeweavers.com> wrote:
> +/* leopad functions */
Typo.

> +static tAudioFileStreamOpen pAudioFileStreamOpen = NULL;
> +static tAudioFileStreamSeek pAudioFileStreamSeek = NULL;
> +static tAudioFileStreamParseBytes  pAudioFileStreamParseBytes = NULL;
> +static tAudioFileStreamClose pAudioFileStreamClose = NULL;
Explicitly initializing these to NULL is superfluous.

> +typedef	struct
> +{
> +    int		nChannels;
> +    int		nBits;
> +    int		rate;
> +} Format;
You have some stray tabs (not just here).

> +    TRACE("ndst %i %p  <-  %i %p\n",*ndst,dst,*nsrc, src);
*ndst and *nsrc are unsigned.

> +        ERR("Feed Error %c%c%c%c\n", (char) (ret>> 24),
> +                                     (char) (ret>> 16),
> +                                     (char) (ret>> 8),
> +                                     (char) ret);
debugstr_an((const char *)&ret, 4); may be easier / nicer.

> +OSStatus Mp3AudioConverterComplexInputDataProc (
> +void Mp3PropertyListenerProc ( void *inClientData, void* inAudioFileStream,
> +void Mp3PacketsProc (
These should probably be static.



More information about the wine-devel mailing list