shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile
Paul Vriens
paul.vriens.wine at gmail.com
Wed Mar 17 10:38:00 CDT 2010
On 03/17/2010 04:21 PM, Ilya Basin wrote:
> @@ -1013,7 +1011,7 @@ static void test_filename(void)
> "%s failed: rc=%d err=%d\n", shell_call,
> rc, GetLastError());
> }
> - else todo_wine
> + else
> {
> ok(rc==test->rc, "%s failed: rc=%d err=%d\n", shell_call,
> rc, GetLastError());
Hi Ilya,
If this is no longer a todo_wine you should change the filename_tests
struct:
/* Test file masked due to space */
{NULL, "%s\\masked file.shlexec", 0x1, 33},
to
/* Test file masked due to space */
{NULL, "%s\\masked file.shlexec", 0x0, 33},
You can even consider removing the "if ((test->todo & 0x1)==0)" as now
there are no more of those tests.
On the one hand it's nice to have these todo constructs, removing them
however is a greater incentive to get the implementation right ;)
--
Cheers,
Paul.
More information about the wine-devel
mailing list