[PATCH 2/5] oleaut32/tests: Make tests working on older systems, prevent crash on some wine boxes

Piotr Caban piotr at codeweavers.com
Thu Mar 18 11:03:26 CDT 2010


Hi,

> If it's acceptable to get something else besides S_OK you should change
> the ok() and add a broken() (still bail out of course).
It's not acceptable to get anything else than S_OK here. I thought skip 
should be used to inform that not all tests are being executed.

> A skip() usually means that something valid happened and we need to bail
> out.
Should I just return from the function without invoking skip?

Regards,
Piotr



More information about the wine-devel mailing list