shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 2]

Paul Vriens at
Mon Mar 22 04:42:33 CDT 2010

On 03/22/2010 07:59 AM, Ilya Basin wrote:
> Hi! Sorry for being annoying, will you accept my patch?

Hi Ilya,

That's not up to us.

Whenever you sent a patch to wine-patch everybody is free to comment (or 
sent a reply that they agree in some specific cases). It's still however 
up to Alexandre whether a patch is accepted and committed.

I can't spot anything obviously wrong with your patch. I must admit that 
this SHELL32_execute function is huge so it could be worthwhile (in the 
future) to split things out of there.

The only thing I'm wondering is why this big piece was added in the 
first place (2004) but that in itself is of course no guarantee it was 

Is it possible to create more tests or is everything possible already 
catered for by that one test?



More information about the wine-devel mailing list