Minor dlls/localspl/tests/localmon.c simplificiation

Nikolay Sivov bunglehead at gmail.com
Sat May 1 13:02:45 CDT 2010


On 5/1/2010 21:52, Gerald Pfeifer wrote:
> On Sat, 24 Apr 2010, Nikolay Sivov wrote:
>    
>>> ChangeLog:
>>> Remove variable res which is not really used from test_XcvClosePort.
>>>        
>> We should better test for return value than remove it.
>>      
> Okay.  Is this something you can look into (or do you have a hint
> on how you'd like such a test to look like)?  It would be great
> could you make this change, but if you have guidance I will do my
> best to give it a try, too.
>
> Gerald
>    
This is a primitive thing, try it if you didn't before.
All you need is to add some lines like:
---
ok(res == ERROR_SUCCESS /*a proper code here*/, "expected ERROR_SUCCESS, 
got %d\n", res);
---
After that run a test on Windows and Wine (using a bot for example) and 
make corrections if needed.




More information about the wine-devel mailing list