Minor dlls/localspl/tests/localmon.c simplificiation

Gerald Pfeifer gerald at pfeifer.com
Sun May 2 18:43:11 CDT 2010


On Sat, 1 May 2010, Nikolay Sivov wrote:
>>>> ChangeLog:
>>>> Remove variable res which is not really used from test_XcvClosePort.
>>> We should better test for return value than remove it.
> This is a primitive thing, try it if you didn't before.
> All you need is to add some lines like:
> ---
> ok(res == ERROR_SUCCESS /*a proper code here*/, "expected ERROR_SUCCESS, got
> %d\n", res);
> ---
> After that run a test on Windows and Wine (using a bot for example) and make
> corrections if needed.

Aaactually, now that I was going to look into this, I recall why I didn't 
consider this originally:  The entire code in that function is inside an
if (0) { }... :-o

But, since you asked for it, I added such tests across the board, made one 
simplification, verified that it actually (if enabled) passes properly on 
Wine and will submit this in a minute.  Then we have things in place when 
the FIXME is addressed.  Plus a learned a thing or two in the process. ;-)

Thanks for your continous feedbac, Nikolay!

Gerlald



More information about the wine-devel mailing list