mshtml: Fix return type value for HTMLBodyElement_put_text.

Jacek Caban jacek at codeweavers.com
Sat May 8 06:45:07 CDT 2010


On 5/8/10 1:07 PM, Gerald Pfeifer wrote:
> The current code does not handle an error coming out of
> nsIDOMHTMLBodyElement_SetText and actually discards whatever nsres
> is set to.
>
> Jacek, is a patch like this okay, should we just remove nsres, or
> is it more complicated than that?
>    

We can't mix nsresult with HRESULT. We should check for failure and 
return something like E_FAIL (and preferably print an error, there is 
something seriously wrong if SetText fails).

Thanks,
     Jacek



More information about the wine-devel mailing list