[PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection

[Juan Lang]

Hi Piotr,

+            if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT)
&& (
+                    res == ERROR_INTERNET_SEC_CERT_DATE_INVALID
+                    || res == ERROR_INTERNET_INVALID_CA
+                    || res == ERROR_INTERNET_SEC_CERT_NO_REV
+                    || res == ERROR_INTERNET_SEC_CERT_REV_FAILED
+                    || res == ERROR_INTERNET_SEC_CERT_REVOKED
+                    || res == ERROR_INTERNET_SEC_INVALID_CERT
+                    || res == ERROR_INTERNET_SEC_CERT_CN_INVALID))
+                res = ERROR_INTERNET_SEC_CERT_ERRORS;

I'm confused.  Is there evidence that native does the same?  This
would be surprising to me, given the existence of
INTERNET_OPTION_SECURITY_FLAGS to mask particular errors.  When are
you trying to accomplish with this patch?  Tests would certainly help.

Thanks,
--Juan