(try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

Henri Verbeet hverbeet at gmail.com
Tue Nov 9 11:39:01 CST 2010


2010/11/9 Rico Schüller <kgbricola at web.de>:
> I made the assumption, because setting the vtbl is the first thing
> d3dcompiler_shader_reflection_init() does.
It is, but you're not supposed to care. Abstractions aren't very
useful if you have to care about the details of their internals.

> Well, a heap free isn't always enough, because there could already be
> allocated data to the object, which then would resolve in lost memory.
>
d3dcompiler_shader_reflection_init() should free anything it allocated
if it's going to fail.



More information about the wine-devel mailing list