[1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

Dmitry Timoshkov dmitry at codeweavers.com
Mon Nov 29 22:29:55 CST 2010

Alexander Puzankov <alxpnv at gmail.com> wrote:

> +    lpProc = mmioInstallIOProc(FOURCC_DOS, (LPMMIOPROC)mmio_test_IOProc, MMIO_INSTALLPROC);
> +    ok(lpProc == (LPMMIOPROC)mmio_test_IOProc, "mmioInstallIOProc error\n");

Please try to avoid this kind of casts, they hide the bugs. Also, if the tests
depend on the following patches in sequence to pass, the tests should be sent
as a last patch ('make test' should succeed after each patch in the sequence).


More information about the wine-devel mailing list