[1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface

[Nikolay Sivov]

  On 10/18/2010 16:03, Jacek Caban wrote:
>  On 10/18/10 1:57 PM, Nikolay Sivov wrote:
>>  On 10/18/2010 15:53, Jacek Caban wrote:
>>>  Hi Nikolay,
>>>
>>> On 10/18/10 11:26 AM, Nikolay Sivov wrote:
>>>>  Get rid of ::get_dataType() forward to IXMLDOMNode interface
>>>>
>>>
>>>      switch ( This->node->type )
>>>      {
>>>      case XML_ELEMENT_NODE:
>>>
>>>
>>> On of points of such patches is to get rid of such switches. In this 
>>> case it seems like introducing new helper return_null_var, adding 
>>> FIXME to extityref implementation and moving element-specific part 
>>> to element.c is way to go. Also it would be nice to have consistent 
>>> TRACEs, so moving them to node-specific objects would be nice.
>>>
>>> Jacek
>> Ok, so you mean use a dummy helper for those nodes that don't have 
>> implementation now
>
> Yes, we already have a few such return_* helper functions in 
> msxml_private.h.
Will take a look.
>
>> and move what is supposed to work already to an object that it 
>> belongs to?
>
> In this case yes. The code is element-specific anyways, so it doesn't 
> make sense to have a function that pretends to be generic.
Agreed.
>
>
> Jacek
>