[2/2] msxml3: fix XSLPattern namespace handling

Alexandre Julliard julliard at winehq.org
Thu Oct 28 05:27:22 CDT 2010

Adam Martinson <amartinson at codeweavers.com> writes:

>  #define U(str) BAD_CAST str
> -#define DBG(str) wine_dbgstr_a((char const*)str)
> +#define DBG(args...) wine_dbg_sprintf((char const*)args)
> +#define RULE(name, args...) TRACE("Got "#name": %s\n", DBG(args))

Again, you can't use varargs macros.

You have a tendency to abuse macros, please try to avoid them as much as
possible. In this case, replacing a standard TRACE by a file-specific
macro is not an improvement, even if it saves a little typing. People
must be able to understand your code without having to look up a ton of
obscure #defines.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list