[PATCH 2/6] gameux: initial implementation of IGameExplorer::AddGame

[Nikolay Sivov]

  On 9/3/2010 13:25, Mariusz Pluciński wrote:
> ---
>  dlls/gameux/Makefile.in          |    2 +-
>  dlls/gameux/gameexplorer.c       |  254 
> +++++++++++++++++++++++++++++++++++++-
>  dlls/gameux/gameux_private.h     |   63 ++++++++++
>  dlls/gameux/tests/gameexplorer.c |   18 ++--
>  4 files changed, 322 insertions(+), 15 deletions(-)
> +/*******************************************************************************
> + * _initGameData
> + *
> + * Internal helper function. Description available in gameux_private.h file
> + */
> +void _initGameData(struct GAME_DATA *GameData)
> +{
> +    GameData->sGDFBinaryPath = NULL;
> +    GameData->sGameInstallDirectory = NULL;
> +}

Do you really need another helper for that? Please use better naming 
like GAMEUX_* for example.

> +void _uninitGameData(struct GAME_DATA *GameData)
> +{
> +    CoTaskMemFree(GameData->sGDFBinaryPath);
> +    CoTaskMemFree(GameData->sGameInstallDirectory);
> +}
Any specific reason you need CoTaskMem* here and not a process heap?

> +    WCHAR sInstanceId[40];
> +    WCHAR sRegistryPath[8192];
Where does this come from? Sizes I mean.