[PATCH] shell32: use flexible arrays to avoid fortify failures

Alexandre Julliard julliard at winehq.org
Sun Sep 19 07:58:42 CDT 2010

Mike Frysinger <vapier at gentoo.org> writes:

> Newer versions of gcc/glibc with fortify checks enabled will complain
> about the handling of the network's szNames field.  Currently it is
> always defined with a length of one which means writing more then a
> single byte will trigger:
> 	In function 'strcpy', inlined from '_ILCreateEntireNetwork' at
> 	dlls/shell32/pidl.c:1762:15:
> 	warning: call to __builtin___strcpy_chk will always overflow destination buffer
> and then at runtime, we hit an abort().
> Since this field is really serving as the header to an arbitrary buffer,
> using a flexible array instead should solve the issue.

What you want is ANYSIZE_ARRAY, which already exists.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list