Use GCC's -Wlogical-op if possible

Gerald Pfeifer gerald at
Sun Sep 19 06:55:13 CDT 2010

On Mon, 4 Jan 2010, Henri Verbeet wrote:
>> I dont see a reason to take that warning serious, as its not a problem 
>> in any case. in kernel32 it just  happens because we use a Macro. 
>> Taking that case(v==1) out of the Macro leads to harder readable code. 
>> So IMHO i would not make -Wlogical-op the default.
> Not using that macro at all would be even more readable. I'm probably
> missing something obvious, but it seems to just do a wsprintfW() with
> "#%d" as format.

I see this has been comitted via b45d4aa161fbbb905fa9142d2757ff3f7952566d.
Thanks!  Looks like this warning is useful after all. ;-)

In fact, doing a build with -Wlogical-op right now it turns out that with
the change above and the work last year there aren't any open issues on
that front any more and I'll submit a patch to make this used by default.


More information about the wine-devel mailing list