RFC [PATCH] ddraw: Prevent refcount underflow

Stefan Dösinger stefandoesinger at gmx.at
Sun Sep 26 05:13:26 CDT 2010


Am 26.09.2010 um 12:01 schrieb Vincent Pelletier:
> Points on which I would like opinions:
> - getting rid of the magic number
~0U or ~((unsigned long) 0)

> - couldn't it actually hide a refcount problem in wine ?
Very likely

> - if not, then would it be good to extend to other refcounts aswell or include
>  in [a local wrapper for] InterlockedDecrement ?
If the problem is indeed an underflow and not a hidden refcount issue(e.g. separated refcounts on surface versions, that's being worked on) it needs a testcase.





More information about the wine-devel mailing list