[PATCH] dinput: Mark internal symbols as hidden

[Marcus Meissner]

On Fri, Apr 29, 2011 at 08:12:36PM +0200, André Hentschel wrote:
> Am 29.04.2011 16:18, schrieb Marcus Meissner:
> > On Fri, Apr 29, 2011 at 07:38:30AM -0600, Vitaliy Margolen wrote:
> >> On 04/29/2011 01:31 AM, Marcus Meissner wrote:
> > 
> > will generate without the visibility line a PLT relocation resolving call:
> > 
> > 0000045c <f>:
> >  45c:	55                   	push   %ebp
> >  45d:	89 e5                	mov    %esp,%ebp
> >  45f:	53                   	push   %ebx
> >  460:	83 ec 04             	sub    $0x4,%esp
> >  463:	e8 ef ff ff ff       	call   457 <__i686.get_pc_thunk.bx>
> >  468:	81 c3 8c 1b 00 00    	add    $0x1b8c,%ebx
> >  46e:	e8 15 ff ff ff       	call   388 <g at plt>
> >  473:	83 c4 04             	add    $0x4,%esp
> >  476:	5b                   	pop    %ebx
> >  477:	5d                   	pop    %ebp
> >  478:	c3                   	ret    
> > 
> > 
> > but with the visibility hidden just a relative call, no relocations:
> > 
> > 0000042c <f>:
> >  42c:	55                   	push   %ebp
> >  42d:	89 e5                	mov    %esp,%ebp
> >  42f:	83 ec 08             	sub    $0x8,%esp
> >  432:	e8 05 00 00 00       	call   43c <g>
> >  437:	c9                   	leave  
> >  438:	c3                   	ret    
> > 
> > 0000043c <g>:
> > 
> > Ciao, Marcus
> > 
> 
> Hi Marcus,
> That's a very cool search&replace job, Wine reduces size and get's faster.
> The question is how much faster? Hope we'll see some benchmarks from you :)

I do not think there will be noticable speed-up.

It however has the possibility to make funny Windows code who has troubles with %ebx
changes work better.

Also the size of the .sos gets smaller a bit (but just in the kilobyte range).

Ciao, Marcus