Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

[Michael Mc Donnell]

On Sat, Aug 6, 2011 at 7:59 PM, Stefan Dösinger <stefandoesinger at gmx.at> wrote:
>> Btw. those FIXMEs might produce a lot of messages (one per vertex). Is
>> there good way to limit the number of messages?
> A common way is something like this
>
> {
>    static BOOL once = false;
>    if (!once)
>    {
>        FIXME("Report this bug to my aunt Tilda please\n");
>        once = TRUE;
>    }
> }
>
> I think there was once a discussion about a FIXME_ONCE macro that took care of this. not sure what happened with that idea.

I've sorta followed Dan's suggestion to use Alexandre's style, except
that I have multiple fixme_once variables. Any idea if this would be
acceptable?

Another solution could be to check the vertex declaration before
running the welding algorithm and print the FIXMEs there. But that
would decouple the location of where the problem is from the printout,
which could be confusing during debugging.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-d3dx9-Only-print-noisy-FIXMEs-once-in-D3DXWeldVertic.patch
Type: text/x-patch
Size: 3851 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110807/59c6636e/attachment.bin>