[PATCH 8/8] ddraw: Avoid double increases of wined3d references.
hverbeet at gmail.com
Mon Aug 8 08:45:52 CDT 2011
2011/8/8 Ričardas Barkauskas <rbarkauskas at codeweavers.com>:
> While normaly this shouldn't even happen, it is distracting when it does.
You can't change ddraw_surface_add_iface() without also changing
surface creation. IIRC the surface is created with references to both
the surface and the texture. I guess keeping a reference to just one
of them would work because of the little shared refcount dance wined3d
surfaces do, but I think I'd prefer to keep that a detail of the
wined3d implementation. However, do note that
ddraw_surface_release_iface() only releases one of them. I think that
may be wrong.
More information about the wine-devel