[PATCH 01/10] cmd: Use CSTR_* instead of hardcoded values as result of CompareStringW

Frédéric Delanoy frederic.delanoy at gmail.com
Fri Aug 19 14:01:08 CDT 2011

2011/8/19 Dan Kegel <dank at kegel.com>:
> Hi Frédéric,
> your patch series seems to have failed the cmd tests:
> batch.c:259: Test failed: unexpected char 0x53 position 0 in line 301
> (got 'Syntax error', wanted '1')
> batch.c:259: Test failed: unexpected char 0x31 position 0 in line 302
> (got '1', wanted '3')
> batch.c:259: Test failed: unexpected char 0x33 position 0 in line 303
> (got '3', wanted '5')
> See http://buildbot.kegel.com/builders/runtests/builds/86
> I'll change the buildbot so it tests each subset of a patch series,
> and pinpoint the one that broke things.
> Incidentally, that 'Syntax error' probably should go to stderr;
> and since the cmd tests ignore stderr, that might fix your failure.

They should eventually go to stderr, but I wouldn't change them right now.
The current tests can run successfully only if the # lines match in
the output / expected files, so putting them to stderr instead might/will break
Also, they are (only?) generated for perfectly valid constructs due to
parsing bugs in current code.

I don't know how your code works, and it's probably done already, but
in certain cases if tests fail, some test files/dirs can be left in
the test directory, so a preliminary cleanup is probably a wise idea.


More information about the wine-devel mailing list