[PATCH 01/10] cmd: Use CSTR_* instead of hardcoded values as result of CompareStringW

Dan Kegel dank at kegel.com
Sat Aug 20 09:22:21 CDT 2011


2011/8/20 Frédéric Delanoy <frederic.delanoy at gmail.com>:
> IIRC someone told me some time ago to resent the whole series with
> (try N+1) for tests processed by testbot. The (resend) is just a hint
> to AJ that that very patch hasn't been revised, just regenerated.

Yeah.  And sometimes the body says "No changes since last try",
in which case maybe even the (resend) hint isn't needed.

> IMHO your patch series recognizer should use the same strategy as
> testbot, for consistency

I see his code at
http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/winetestbot;a=blob;f=lib/WineTestBot/Patches.pm
http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/winetestbot;a=blob;f=lib/WineTestBot/PendingPatchSets.pm
and can see a few details, but his overall strategy is hard to discern
in a quick read.

> and wait for the whole series to be available before processing can start.

That I do.
- Dan



More information about the wine-devel mailing list