ieframe/tests: Skip rest of tests if CoCreateInstance failed.

Jacek Caban jacek at codeweavers.com
Thu Aug 25 06:59:38 CDT 2011


On 08/25/11 13:55, Octavian Voicu wrote:
> On Thu, Aug 25, 2011 at 2:38 PM, Jacek Caban<jacek at codeweavers.com>  wrote:
>> Where do you get such a broken installation from? I don't see such failures
>> on test.winehq.org.
> Hi Jacek,
>
> It's not only me, see [1]. It fails every time on WOW64 giving
> something like this [2].
> It's a different crash from the win64 one (which is caused by an
> assertion failure in oleaut32/tmarshal.c).

Those are failures on Wine, so tests are fine, it's Wine that needs fixing.

>
> [not related to this patch] It's strange that iexplore.exe from
> Program Files (x86) folder is used also for GIF, JPEG, PNG open
> handlers, and for HTML icons, but on the main Classes tree, so they
> are broken.
>
> Should 32-bit iexplore.exe be copied in Program Files (x86)? A 32-bit
> process should be able to communicate with 64-bit iexplore.exe via
> RPC, right?

We should do whatever Windows does.

> PS: crash reported by testbot was already there, just that ieframe
> tests are usually skipped on NT4.

Yeah, testbot is not smart enough to skip tests if tested DLL is not 
present (unlike winetest).

Jacek



More information about the wine-devel mailing list