services: Remove an unused variable.
fgouget at codeweavers.com
Sat Aug 27 03:40:53 CDT 2011
On Fri, 26 Aug 2011, Frédéric Delanoy wrote:
> > - DWORD err;
> > const WCHAR *argv;
> > service = services_list[i];
> > argv = service->name;
> > argv = NULL;
> > - err = service_start(service, 1, argv);
> > + service_start(service, 1, argv);
> > /* FIXME: do something if the service failed to start */
> > release_service(service);
> > }
> Wouldn't it be better to do something with err rather than muting (as
> the comment suggests)?
Maybe but what? The FIXME does not even say. In the meantime a FIXME
comment is not a good enough reason to keep a compilation warning imho.
And conversely fixing a compilation warning is not 'muting' a FIXME
Francois Gouget <fgouget at codeweavers.com>
More information about the wine-devel