[1/5] ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Am 29.08.2011 um 21:38 schrieb Henri Verbeet:

> On 29 August 2011 20:53, Stefan Dösinger <stefan at codeweavers.com> wrote:
>> On Monday 29 August 2011 19:40:13 Henri Verbeet wrote:
>>> On 29 August 2011 19:20, Stefan Dösinger <stefan at codeweavers.com> wrote:
>>>> +/* Note that this function writes the full sizeof(DDSURFACEDESC2) size,
>>>> don't use it
>>> 
>>> So no need to clear it first.
>> Well, the clear is part of the code that writes to the structure. The rest of
>> the code only writes members that are set in the source DDSURFACEDESC.
>> 
> If they aren't set in the source structure we should never read them anyway.
Technically that's true for this specific function since the result is only used by our code and never the application. Yet I prefer to keep the memset for consistency with other code that handles DDSURFACEDESC(2) structures.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)

iQIcBAEBAgAGBQJOW+6PAAoJEN0/YqbEcdMw9Q4QAIzL0rJ/RQ+pz2eS2Bm6Ojf2
aiOLyWe5Bwuc+qBL3uvt+l+L/PiUQSHXCViDyjvOlZL9IK/fdVfcEDLiWd8/884N
FV9NtnR0MB5nUwOHpZYk70zXocY+Fyi47b7yuC0SC9DU8Pf1y+MvvTyu30GC8T5t
J/vG6LLUlkuSDSsmomg5GAAEEGEst25D21m9nVlt8IiaaqP1oNdsshSwh3FWjP7w
PmVR1Pzi2gNIyhRrXuTasbHFtgME4HwUrjgglRe4R/dacMopfLAHM+swxHQykgmw
HGLYsRhKFMoegsAsiAkIARyF4Oc73uJaVdhcBP/mRXPcGBT93cICV69XbNgGJ7AN
xdEfxFWVujCF0x94KTC1XLEt+sM1bkjlIoITcPsqEjbrm16jU3jtuSLL58KAOtsh
QVlksMQ8b3Fo0zY/tKzucBQoAZpDgMJY4EvkfcB5HLqIRlHHK/ZzMhe6vjEzZfZn
0ELwEl2+QRaAITLEnmK8DxL/PtI9unemLAeOOZkigi8ooeo6KVOM5g5VqCqhEhMp
XNi1yQdkINthCZpPqDWnx9SnYJS3bqlUqXHi+SoZnuwBc41AFctsYjPVeRnIF6Sm
zf6Ae7MD2piA/elrHlCyQfS5CQWUmkY0xNZDGHD0sBEsh5SYFFbPoM4kJAKJZrTq
OJR39TbofSSvpESIua2n
=Mzq4
-----END PGP SIGNATURE-----