[PATCH 1/5] cmd/tests: add more tests for command line parsing

Frédéric Delanoy frederic.delanoy at gmail.com
Wed Aug 31 03:34:07 CDT 2011

2011/8/31 Martin Wilck <mwilck at arcor.de>:
>> IMHO we should probably split it only when it's reasonably complete,
>> where we'd have a broader view.
> Well, it's up to you. I just made an attempt to merge my stuff into
> test_builtins and gave up after 2 hours :-(
>> Also, test_parsing name is probably a bit too generic (not that
>> test_builtins isn't ;) )
>> But you can still submit it in the meantime, maybe AJ will accept it.
>> Just make sure there's no duplication
> AFAICT there is no real duplication. 4 TODOs in the current
> test_builtins are removed by the last of my patches, so there is some
> overlap, but I wouldn't call it a duplicate.
Fair enough.

>> Also, when you have to make tests work on NT4->2k8 *and* wine at *all*
>> times, you sometimes have to make your hands dirty.
> I tested my stuff only on XP. Perhaps someone can help me out testing
> other native versions.

You should subscribe to testbot. It has a shitload of available VMs to
tests your patches against.
Actually, my current test procedure is the following:
1. Write a passing test/expected result on a reasonably old win
version (e.g. 2k or XP)
2. Submit to testbot (http://wiki.winehq.org/WineTestBot) to check it
works on win versions (sometimes it fails on NT4 or other win version
due to random bugs)
    If it fails, iterate until it passes on windows
3. Check if it works on wine (make testclean && make test)
    If it works, you're done.
    Else, make changes and goto 2

>> Just ask if you don't understand the @keywords at . Doc is a bit lacking;
>> I might add a quick wiki help page if desired.
> Yes, that'd be helpful (IMO just a README file in the tests/ directory
> would be even better). It took me a while to get started with the cmd
> testing code.

Yeah me too. Wine's learning curve is steep.
Did you read http://www.winehq.org/docs/winedev-guide/index ?  It's
not entirely relevant to cmd's tests but is a good starting point.
I'll write a patch adding a README.
There's also IRC #winehackers channel on Freenode.

>> Did you correctly register via
>> http://www.winehq.org/mailman/listinfo/wine-patches?
> I was hoping this was an open ML (and last time tried it was). OK, I'll
> subscribe and re-submit.

Think "spam".
Also you might want to submit smaller patches, it helps with
regression testing (and eases code review by the committer)

>> Nice job by the way.
> Thanks a lot, it seems that you took on a big task with cmd, good luck!
> Martin


More information about the wine-devel mailing list