[PATCH 2/4] msi: reorder tables to optimize condition evaluation

[Dan Kegel]

On Wed, Aug 31, 2011 at 3:10 AM,  <buildbot at buildbot.kegel.com> wrote:
> The Buildbot has detected a failed build on builder runtests while building Wine.
> Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/136
> BUILD FAILED: failed shell_3
>
>
> For more info about this message, see http://wiki.winehq.org/BuildBot

This breaks loading of wine's gecko here:

../../../tools/runtest -q -P wine -M ieframe.dll -T ../../.. -p
ieframe_test.exe.so webbrowser.c && touch webbrowser.ok
wine: Unhandled page fault on write access to 0xa06291fc at address
0x407537e9 (thread 002c), starting debugger...
Backtrace:
=>0 WHERE_execute+0x17a(view=0x11fe58, record=(nil)) [dlls/msi/where.c:821]
  1 SELECT_execute+0x9d(view=0x138408, record=(nil)) [dlls/msi/select.c:181]
  2 MSI_ViewExecute+0xb4(query=0x11fce0, rec=(nil)) [dlls/msi/msiquery.c:457]
  3 get_product_code+0x55(db=0x12e6f0) [dlls/msi/package.c:1393]
  4 get_local_package+0x58(filename="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi",
localfile="??") [dlls/msi/package.c:1477]
  5 MSI_OpenPackageW+0x1f8(szPackage="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi",
pPackage=0x33fb14) [dlls/msi/package.c:1546]
  6 MsiInstallProductW+0xb3(szPackagePath="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi",
szCommandLine=0x0(nil)) [dlls/msi/msi.c:245]
  7 install_file+0x24(file_name="Z:\usr\share\wine\gecko\wine_gecko-1.3-x86.msi")
[dlls/appwiz.cpl/addons.c:164]
  8 install_from_unix_file+0x22b(file_name="/usr/share/wine/gecko/wine_gecko-1.3-x86.msi")
[dlls/appwiz.cpl/addons.c:207]
  9 install_from_default_dir+0x11f() [dlls/appwiz.cpl/addons.c:276]
  10 install_wine_gecko+0x2f() [dlls/appwiz.cpl/addons.c:490]
  11 start_params+0x3f(params="install_gecko") [dlls/appwiz.cpl/appwiz.c:978]
  12 CPlApplet+0x61(hwndCPL=0x6002e, message=0xa, lParam1=0,
lParam2=0x12dbce) [dlls/appwiz.cpl/appwiz.c:1013]
  13 Control_DoLaunch+0x524(panel=0x33fd50, hWnd=0x6002e,
wszCmd="appwiz.cpl install_gecko") [dlls/shell32/control.c:820] in
shell32 (0x0033fd20)
  14 Control_RunDLLW+0xde(hWnd=0x6002e, hInst=(nil), cmd="appwiz.cpl
install_gecko", nCmdShow=0x5) [dlls/shell32/control.c:846] in shell32
(0x0033fd80)
  15 launch+0x35(what="appwiz.cpl install_gecko")
[programs/control/control.c:55]
  16 wWinMain+0x182(hInst=0x684c0000, hPrev=(nil),
lpszCmdLine="appwiz.cpl install_gecko", nCmdShow=0x1)
[programs/control/control.c:85]
  17 wmain+0x10c(argc=0x3, argv=0x110380) [dlls/winecrt0/exe_wmain.c:50]
0x407537e9 WHERE_execute+0x17a [dlls/msi/where.c:821] in msi: movl
 %edx,0x0(%eax)
821             tables[i++] = table;