[PATCH 1/5] cmd/tests: add more tests for command line parsing

Martin Wilck mwilck at arcor.de
Tue Aug 30 14:31:18 CDT 2011

Hi Frédéric,

> Some of those tests are already present in the test_builtins.cmd*
> (e.g. the spacing tests)
> You should probably integrated your tests in there: that makes it
> easier to spot regressions and helps prevent tests duplication

I can certainly do that if you prefer (and I will), but I don't agree
that having all tests in a single big file is an advantage. Splitting
the unit tests over multiple files would make it much easier to relate
output lines to script lines and do focused work on certain areas. For
anyone who doesn't work on it regularly, test_builtins.cmd is a nightmare.

> Also, see http://www.winehq.org/pipermail/wine-devel/2011-August/091817.html

I'm not sure why you're telling me that. My patches aren't about
performance but correctness. They won't affect performance negatively,


PS: any idea why my patches didn't make it to wine-patches?

More information about the wine-devel mailing list