[PATCH 1/5] cmd/tests: add more tests for command line parsing

Martin Wilck mwilck at arcor.de
Tue Aug 30 18:08:12 CDT 2011

> IMHO we should probably split it only when it's reasonably complete,
> where we'd have a broader view.

Well, it's up to you. I just made an attempt to merge my stuff into
test_builtins and gave up after 2 hours :-(

> Also, test_parsing name is probably a bit too generic (not that
> test_builtins isn't ;) )
> But you can still submit it in the meantime, maybe AJ will accept it.
> Just make sure there's no duplication

AFAICT there is no real duplication. 4 TODOs in the current
test_builtins are removed by the last of my patches, so there is some
overlap, but I wouldn't call it a duplicate.

> Also, when you have to make tests work on NT4->2k8 *and* wine at *all*
> times, you sometimes have to make your hands dirty.

I tested my stuff only on XP. Perhaps someone can help me out testing
other native versions.

> Just ask if you don't understand the @keywords at . Doc is a bit lacking;
> I might add a quick wiki help page if desired.

Yes, that'd be helpful (IMO just a README file in the tests/ directory
would be even better). It took me a while to get started with the cmd
testing code.

> Did you correctly register via
> http://www.winehq.org/mailman/listinfo/wine-patches?

I was hoping this was an open ML (and last time tried it was). OK, I'll
subscribe and re-submit.

> Nice job by the way.

Thanks a lot, it seems that you took on a big task with cmd, good luck!


More information about the wine-devel mailing list