[PATCH 2/2] comdlg32: Widen buffer to accomodate Catalan translation
Paul Chitescu
paulc at voip.null.ro
Fri Dec 16 03:06:24 CST 2011
On Friday 16 December 2011 09:48:01 am Alex Henrie wrote:
> ---
> dlls/comdlg32/filedlg.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c
> index 5f80519..8637944 100644
> --- a/dlls/comdlg32/filedlg.c
> +++ b/dlls/comdlg32/filedlg.c
> @@ -1504,7 +1504,7 @@ static LRESULT FILEDLG95_InitControls(HWND hwnd)
> }
> else if (fodInfos->DlgInfos.dwDlgProp & FODPROP_SAVEDLG)
> {
> - WCHAR buf[16];
> + WCHAR buf[17];
> LoadStringW(COMDLG32_hInstance, IDS_SAVE_AS, buf,
> sizeof(buf)/sizeof(WCHAR)); SetWindowTextW(hwnd, buf);
> }
Don't be so cheap, if you had problems other languages my have problems as
well. Make it a little larger than absolute minimum, let's say 20.
Besides, the memory is allocated or aligned at at least 32 bits boundaries so
a 17 or 18 WCHAR buffer will use the same amount of memory.
Paul
More information about the wine-devel
mailing list