programs: Add winemsibuilder.

Joris Huizer joris_huizer at yahoo.com
Tue Feb 1 06:38:21 CST 2011


While skimming through the new patches, I found:

> +WCHAR *encode_stream( const WCHAR *in )
> +{
> +    DWORD c, next, count;
> +    WCHAR *out, *p;
> +
> +    count = strlenW( in );
> +    if (count > MAX_STREAM_NAME)
> +        return NULL;
> +
> +    count += 2;
> +    out = HeapAlloc( GetProcessHeap(), 0, count
> * sizeof(WCHAR) );
> +    p = out;

You aren't checking for out-of-memory condition here. As you seem to cover all the other possible errors, I thought to let you know

HTH,
Joris


      



More information about the wine-devel mailing list