Try to Implement my first Stub function - AbortPrinter() - (try 2).
lmaury at gmail.com
Wed Feb 9 09:09:31 CST 2011
Thank you for your reply.
On 08/02/11 18:13, Andrew Eikum wrote:
> On 02/08/2011 10:48 AM, Loïc Maury wrote:
>>> First of all set your tab size to 8, and ask your editor to not use
>>> at all.
>> I have modified my editor, but I don't know if it 's correct now ?
> The indentation looks fine to me now. You've got an extra newline
> after the "if(printer->doc)" block and before the "else." The
> formatting on the TRACE statement is still bizarre. Fix the commas and
> put it on just a couple of lines. No reason for one line and a ton of
> whitespace for each parameter. See line 1944 for an example.
Ok, it's correct now ?
> Otherwise, two little things I noticed.
> First, you must also check the return value for HeapAlloc().
> Second, you should be using the LIST_FOR_EACH_ENTRY_SAFE macro, which
> will eliminate the local cursor and cursor2 variables and make the
> code a little more simple. (Unless there's something I'm missing?)
Ok, I have modified and removed cursor and cursor2 by job and next_job,
and list_remove(cursor) by list_remove(&job->entry).
> Almost done, nice work :)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the wine-devel