[1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

Alistair Leslie-Hughes leslie_alistair at hotmail.com
Wed Feb 16 04:21:08 CST 2011


Hi Jacek,

--------------------------------------------------
From: "Jacek Caban" <jacek at codeweavers.com>
Sent: Wednesday, February 16, 2011 8:44 PM
To: "Alistair Leslie-Hughes" <leslie_alistair at hotmail.com>
Cc: "Wine Devel" <wine-devel at winehq.org>
Subject: Re: [1/4] mshtml: Ignore IActiveScript interface for 
IXMLHTTPRequest (resend)

>>
>> We need to just ignore two know interfaces IActiveScript and IDispatchEx.
>
> Not really. For example, you will find need for silencing IID_IDispatchJS 
> pseudo-interface and its native jscript equivalent once it will be 
> actually usefull for scripts. These are not interfaces apps query for and 
> they are trivial to find once you know you're dealing with scripting. And 
> please don't tell me that expecting enabling tracing for debugged DLL is 
> something making debugging hard.
No debugging isn't that hard. I was testing with a web page and these 
interfaces
are repeated in the trace a lot, and it's easier to deal with a name instead
of a GUID.

>
>> If we are going to stop silencing interfaces, Should be just remove the 
>> ones already in webbrowser(shdocvw)?  No, We do this so other developers 
>> can see that these interfaces are not supported and so they don't need to 
>> waste there time researching them.  We silence interfaces like the above 
>> in other places, so why no here?
>
> Each case is different and you need to consider what having this FIXME is 
> gaining us. XMLHTTPRequest object has one interfaces interesting for apps 
> and some more needed by stuff like scripting or security manager that are 
> easy to find missing and obvious to expect. Objects like WebBrowser 
> control have tons of interfaces that app may query for and in its case, 
> the FIXME has proven to be useful.
>
I've sent a patch that lists the known noisy interfaces, and changes the 
FIXME
to a WARN.

Best Regards
 Alistair Leslie-Hughes 




More information about the wine-devel mailing list