RFC: Patch to change what sets the is_win9x in riched20/tests

Paul Vriens paul.vriens.wine at gmail.com
Tue Feb 22 01:42:20 CST 2011


On 02/22/2011 01:21 AM, James McKenzie wrote:
> All:
>
> Upon examining other test code that creates a variable called is_win9x,
> I realized that using get_version and comparing it to a fixed value may
> not be best for the riched20 tests and have attached a proposed change
> to how this variable is set. It uses a called function, lstrcmpW and if
> it does not exist, the variable is set to a false value. This change has
> been tested on the testbot for
> Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no
> discrepancies were found.

Win9x tests are no longer run with winetest. I also see that Austin sent 
some 9x cleanup patches. That said, I think the best way is to get rid 
of all the win9x 'hacks' in editor.c and rely on the fact that we have NT4+.

-- 
Cheers,

Paul.



More information about the wine-devel mailing list