[2/5] msxml3: Remove appendChild() forward (try2)
Jacek Caban
jacek at codeweavers.com
Wed Feb 23 06:25:27 CST 2011
On 2/23/11 1:21 PM, Nikolay Sivov wrote:
> - TRACE("(%p)->(%p %p)\n", This, newChild, outNewChild);
> -
> - hr = IXMLDOMNode_get_nodeType(newChild,&type);
> + hr = IXMLDOMNode_get_nodeType(child,&type);
> if(FAILED(hr) || type == NODE_ATTRIBUTE) {
> - if(outNewChild) *outNewChild = NULL;
> + if (outChild) *outChild = NULL;
> return E_FAIL;
> }
This check for an attribute node shouldn't be needed here. Attribute
node may just return failure instead of forwarding the call. Also I'd
expect the same from other nodes that can't have children, like text node.
Jacek
More information about the wine-devel
mailing list