d3dx9_36: Stub ID3DXRenderToSurface, with tests

Henri Verbeet hverbeet at gmail.com
Mon Feb 28 06:58:08 CST 2011


On 27 February 2011 20:22, Misha Koshelev <misha680 at gmail.com> wrote:
> +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID riid, void **ppobj)
> +{
> +    ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface);
You don't actually need "This" here.

> +        return D3D_OK;
S_OK is more appropriate for QueryInterface.

> +    WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
> +    return E_NOINTERFACE;
> +}
You should set "*ppobj" to NULL here, unless there's a reason not to.



More information about the wine-devel mailing list