[PATCH 2/2] shell32: Don't fill SHITEMID data with random values if file doesn't exist

Alexandre Julliard julliard at winehq.org
Thu Jan 6 04:33:02 CST 2011


Piotr Caban <piotr at codeweavers.com> writes:

> @@ -538,6 +538,8 @@ static char* UNIXFS_build_shitemid(char *pszUnixPath, LPBC pbc, void *pIDL) {
>      if (stat(pszUnixPath, &fileStat)){
>          if (must_exist || errno != ENOENT)
>              return NULL;
> +
> +        memset(&fileStat, 0, sizeof(struct stat));

That may not be random, but it's still wrong values. It seems to me that
this is what the IFileSystemBindData should be used for.

-- 
Alexandre Julliard
julliard at winehq.org




More information about the wine-devel mailing list