RFC: Richedit: Test Patch for EM_SETMARGINS

James McKenzie jjmckenzie51 at earthlink.net
Sun Jan 16 13:29:17 CST 2011

On 1/16/11 10:58 AM, Charles Davis wrote:
> On 1/16/11 10:53 AM, James McKenzie wrote:
>> On 1/16/11 10:27 AM, Nikolay Sivov wrote:
>>> On 1/16/2011 20:17, James McKenzie wrote:
>>>>>> +    todo_wine {
>>>>>> +        SendMessageW(hwndRichEdit, EM_SETMARGINS, EC_USEFONTINFO,
>>>>>> +    }
>>>>> Hm.
>>>> This is one of the test cases that was recommended and it appears to
>>>> be the only one that 'works'.
>>> There's no test in this line, maybe that's why it 'works'.
>> No, USEFONTINFO is equal to 65,535 (0xFFFF) and in the other cases sets
>> the margin to either an overflow or underflow condition.  This test does
>> not move the margins.  Microsoft's documentation is lacking in how to
>> use this feature and I could not find a good case on the Internet.
>> Perhaps I used wrong search criteria or no one is using this capability.
> He means there's no ok() macro call inside the todo_wine block. todo
> blocks only have an effect on ok() macros.
I will remove the todo_wine from this call.  It feeds back a 'fixme' for 
now.  I'll provide a 'cleaner' patch later today after working on it 
some more.

James McKenzie

More information about the wine-devel mailing list